Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip ci] added another animation style #212

Merged
merged 4 commits into from
Mar 17, 2022
Merged

[skip ci] added another animation style #212

merged 4 commits into from
Mar 17, 2022

Conversation

shimwell
Copy link
Member

Proposed changes

Improved an example to include another style of animation

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #212 (b27c818) into develop (96f3eb1) will increase coverage by 0.55%.
The diff coverage is n/a.

❗ Current head b27c818 differs from pull request most recent head 4a8396c. Consider uploading reports for the commit 4a8396c to get more accurate results

@@             Coverage Diff             @@
##           develop     #212      +/-   ##
===========================================
+ Coverage    95.64%   96.19%   +0.55%     
===========================================
  Files           79       79              
  Lines         5263     5263              
===========================================
+ Hits          5034     5063      +29     
+ Misses         229      200      -29
Impacted Files Coverage Δ
paramak/shape.py 95.21% <0.00%> (+1.88%) ⬆️
paramak/utils.py 94.89% <0.00%> (+2.91%) ⬆️
paramak/reactor.py 77.44% <0.00%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f3eb1...4a8396c. Read the comment docs.

@shimwell shimwell merged commit 1e8c3fa into develop Mar 17, 2022
@shimwell shimwell deleted the adding_line_animation branch March 17, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shimwell